Generalize gemma vision mask to videos#45185
Merged
zucchini-nlp merged 2 commits intohuggingface:mainfrom Apr 2, 2026
Merged
Conversation
Member
Author
|
run-slow: gemma3, paligemma, git |
Contributor
|
This comment contains models: ["models/gemma3", "models/git", "models/paligemma"] |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Apr 2, 2026
| This function adds the correct offsets to the `q_idx` and `kv_idx` as the torch API can only accept lengths, | ||
| not start and end indices. | ||
| Args: | ||
| vision_group_ids (`torch.Tensor`): |
Collaborator
There was a problem hiding this comment.
Suggested change
| vision_group_ids (`torch.Tensor`): | |
| group_ids (`torch.Tensor`): |
Collaborator
There was a problem hiding this comment.
as it includes text group as well
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gemma3, git, paligemma |
marvinzh
pushed a commit
to marvinzh/transformers
that referenced
this pull request
Apr 3, 2026
* more general inner mask * arthur's comment - rename everywhere
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Apr 4, 2026
* more general inner mask * arthur's comment - rename everywhere
sirzechs66
pushed a commit
to sirzechs66/transformers
that referenced
this pull request
Apr 18, 2026
* more general inner mask * arthur's comment - rename everywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If we have videos, the token type ids will be
2but the current fn checks only image token types. This PR generalizes it rely only onvision_group_idsinstead of token types