Skip to content

Fix ty for transformers cli#45190

Merged
vasqu merged 10 commits intomainfrom
ty-cli
Apr 14, 2026
Merged

Fix ty for transformers cli#45190
vasqu merged 10 commits intomainfrom
ty-cli

Conversation

@SunMarc
Copy link
Copy Markdown
Member

@SunMarc SunMarc commented Apr 2, 2026

What does this PR do?

This patch extends ty check to src/transformers/cli.

Supersedes #44566. I've added some of the changes in this PR

@SunMarc SunMarc requested a review from tarekziade April 2, 2026 13:54
@tarekziade tarekziade requested a review from vasqu April 2, 2026 13:57
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Comment thread src/transformers/cli/serving/response.py Outdated
Copy link
Copy Markdown
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delays, just some smaller comments overall

Comment thread src/transformers/cli/serving/chat_completion.py Outdated
Comment thread src/transformers/cli/serving/response.py Outdated
Comment thread src/transformers/cli/serving/utils.py Outdated
Comment thread src/transformers/cli/serving/utils.py Outdated
Comment thread src/transformers/cli/system.py
Comment thread src/transformers/tokenization_utils_base.py Outdated
@SunMarc SunMarc requested a review from tarekziade April 13, 2026 13:47
@SunMarc
Copy link
Copy Markdown
Member Author

SunMarc commented Apr 13, 2026

Can you have one last check @tarekziade ?

Copy link
Copy Markdown
Collaborator

@tarekziade tarekziade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@SunMarc SunMarc added this pull request to the merge queue Apr 14, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 14, 2026
@vasqu vasqu added this pull request to the merge queue Apr 14, 2026
Merged via the queue into main with commit 5e3af51 Apr 14, 2026
29 checks passed
@vasqu vasqu deleted the ty-cli branch April 14, 2026 16:53
sirzechs66 pushed a commit to sirzechs66/transformers that referenced this pull request Apr 18, 2026
* Fix ty for transformers cli

* ty

* await class

* style

* adress comments

* Fix !

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants