Add edge case tests for out-of-range token id decoding in Qwen2 tokenizer#45191
Closed
saslifat-gif wants to merge 2 commits intohuggingface:mainfrom
Closed
Add edge case tests for out-of-range token id decoding in Qwen2 tokenizer#45191saslifat-gif wants to merge 2 commits intohuggingface:mainfrom
saslifat-gif wants to merge 2 commits intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: qwen2 |
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=45191&sha=81e61e |
Member
|
Hi @saslifat-gif, we'd prefer no small PRs right now that aren't significant bugfixes or feature additions! We're trying to cut down on the overall volume because of agent spam. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Qwen2 tokenizer test file had no custom test methods — only integration
constants inherited from TokenizerTesterMixin.
This PR adds a test documenting two untested edge cases in decode():
Before (no test, behavior undocumented):
After (behavior documented and regression-protected):
string — tested with assertEqual(decoded, "")
Both behaviors verified consistent between Qwen2Tokenizer (slow) and fast
tokenizer on Qwen/Qwen2.5-VL-7B-Instruct.