Configuration insoncistencies#45194
Closed
zucchini-nlp wants to merge 6 commits intohuggingface:mainfrom
Closed
Conversation
zucchini-nlp
commented
Apr 2, 2026
|
|
||
| self.audio_config = CONFIG_MAPPING[self.audio_config["model_type"]](**self.audio_config) | ||
| elif self.audio_config is None: | ||
| self.audio_config = CONFIG_MAPPING["musicflamingo_encoder"]() |
Member
Author
There was a problem hiding this comment.
model_type = musicflamingo_encoder doesn't exist
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
I think we can keep it as part of the bigger PR, closing |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: eurobert, fastspeech2_conformer, kosmos2, musicflamingo, nanochat, nougat, qwen2_5_vl, qwen2_vl, qwen3_5, qwen3_5_moe, qwen3_vl, qwen3_vl_moe, speecht5, vibevoice_asr, voxtral_realtime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes:
PretrainedConfigwithPreTrainedConfigconfiguration_model.py, instead resolve via modularQwen2VLConfigandQwen2VLVisionConfig. Vision backbones are not auto-mapped yet and were not even a PreTrainedModel in the past. So it won't break anything, and official checkpoint don't havemodel_typesaved anywayVisionEncoderDecoderConfigwith a different model type. Rn in config's auto mapping, theVisionEncoderDecoderConfigresolves tovision-encoder-decoderby accident, we are just lucky it comes last and overwrites nougat. IMO no config class should map to two model types, since model type is aClassVarI wonder if we should be adding linter checks on a few of these, specifically
no importing from other modelsandeach config class maps to single model_type?P.S. Uncovered everything when trying to dynamically build the MAPPING in #45018