nomic_bert: make the test suitable for general device.#45209
Merged
ydshieh merged 1 commit intohuggingface:mainfrom Apr 10, 2026
Merged
nomic_bert: make the test suitable for general device.#45209ydshieh merged 1 commit intohuggingface:mainfrom
ydshieh merged 1 commit intohuggingface:mainfrom
Conversation
Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: nomic_bert |
ydshieh
reviewed
Apr 9, 2026
| expected_slice = Expectations( | ||
| { | ||
| ("cuda", None): torch.tensor( | ||
| (None, None): torch.tensor( |
Collaborator
There was a problem hiding this comment.
Thanks! Guess the same value work for XPU too (?)
Collaborator
|
@kaixuanliu Could you share the error log? It should still be able to use the value from the single |
ydshieh
approved these changes
Apr 9, 2026
Contributor
Author
|
@ydshieh , For XPU device, before the fix, it will fail like: |
Collaborator
|
OK, so if only ("cuda") specified, other device couldn't get the value from it. I will revise the mechanism ... Thanks a lot |
sirzechs66
pushed a commit
to sirzechs66/transformers
that referenced
this pull request
Apr 18, 2026
…5209) Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ydshieh pls help review, thx!