Add MoE to Gemma4 TP plan#45219
Merged
Cyrilvallez merged 2 commits intohuggingface:mainfrom Apr 8, 2026
Merged
Conversation
Signed-off-by: Wang, Yi <yi.a.wang@intel.com>
Rocketknight1
previously approved these changes
Apr 8, 2026
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
Happy to approve this one and people can yell at me later if there's any problem!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
@Rocketknight1 thanks for the approval, I check the failure in ci, nothing to do with the PR |
Cyrilvallez
changed the title
Cyrilvallez
approved these changes
Apr 8, 2026
Member
Cyrilvallez
left a comment
Cyrilvallez
left a comment
There was a problem hiding this comment.
Thanks, indeed the MoE part was forgotten! Sorry @Rocketknight1, I dismissed your review as I saw it was in the merging queue and I panicked thinking the mlp part should be removed, but it should stay as well haha
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gemma4 |
bigshanedogg
pushed a commit
to bigshanedogg/transformers
that referenced
this pull request
Apr 9, 2026
reduce memory for gemma4 moe model in tp Signed-off-by: Wang, Yi <yi.a.wang@intel.com> Co-authored-by: Cyril Vallez <cyril.vallez@huggingface.co>
Cyrilvallez
added a commit
that referenced
this pull request
Apr 9, 2026
reduce memory for gemma4 moe model in tp Signed-off-by: Wang, Yi <yi.a.wang@intel.com> Co-authored-by: Cyril Vallez <cyril.vallez@huggingface.co>
sirzechs66
pushed a commit
to sirzechs66/transformers
that referenced
this pull request
Apr 18, 2026
reduce memory for gemma4 moe model in tp Signed-off-by: Wang, Yi <yi.a.wang@intel.com> Co-authored-by: Cyril Vallez <cyril.vallez@huggingface.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
google/gemma-4-26B-A4B-it
tp 2, memory is 46G per rank wo the change, drop to about 25G w per rank with the change