Conversation
- Remove leftover debug artifacts: commented-out `from transformers import *`, all `# breakpoint()` calls - Move inline imports to top-level: `importlib`, `re`, `TokenizersBackend`, `VibeVoiceAcousticTokenizerFeatureExtractor`, `FastSpeech2ConformerTokenizer` - Fix 3-space indent in `_to_tuple` - Remove no-op in `fill_result_with_error` - Add `CHECKPOINT_REVISIONS` and `CHECKPOINT_SUBFOLDERS` module-level dicts to replace repetitive if/elif chains in `build_processor` - Extract `_build_model_tester_and_get_config` helper to eliminate duplicated tester instantiation + config-retrieval logic in `get_tiny_config` Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
louzongzhi
pushed a commit
to louzongzhi/transformers
that referenced
this pull request
Apr 6, 2026
* clean * cleanup 1 * Minor cleanups to create_dummy_models.py for readability - Remove leftover debug artifacts: commented-out `from transformers import *`, all `# breakpoint()` calls - Move inline imports to top-level: `importlib`, `re`, `TokenizersBackend`, `VibeVoiceAcousticTokenizerFeatureExtractor`, `FastSpeech2ConformerTokenizer` - Fix 3-space indent in `_to_tuple` - Remove no-op in `fill_result_with_error` - Add `CHECKPOINT_REVISIONS` and `CHECKPOINT_SUBFOLDERS` module-level dicts to replace repetitive if/elif chains in `build_processor` - Extract `_build_model_tester_and_get_config` helper to eliminate duplicated tester instantiation + config-retrieval logic in `get_tiny_config` Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * remove other bad blocks * remove comment * fix wrong _models * revert * fix * fix * update workflow (to be continued) --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
louzongzhi
pushed a commit
to louzongzhi/transformers
that referenced
this pull request
Apr 6, 2026
* clean * cleanup 1 * Minor cleanups to create_dummy_models.py for readability - Remove leftover debug artifacts: commented-out `from transformers import *`, all `# breakpoint()` calls - Move inline imports to top-level: `importlib`, `re`, `TokenizersBackend`, `VibeVoiceAcousticTokenizerFeatureExtractor`, `FastSpeech2ConformerTokenizer` - Fix 3-space indent in `_to_tuple` - Remove no-op in `fill_result_with_error` - Add `CHECKPOINT_REVISIONS` and `CHECKPOINT_SUBFOLDERS` module-level dicts to replace repetitive if/elif chains in `build_processor` - Extract `_build_model_tester_and_get_config` helper to eliminate duplicated tester instantiation + config-retrieval logic in `get_tiny_config` Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * remove other bad blocks * remove comment * fix wrong _models * revert * fix * fix * update workflow (to be continued) --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
sirzechs66
pushed a commit
to sirzechs66/transformers
that referenced
this pull request
Apr 18, 2026
* clean * cleanup 1 * Minor cleanups to create_dummy_models.py for readability - Remove leftover debug artifacts: commented-out `from transformers import *`, all `# breakpoint()` calls - Move inline imports to top-level: `importlib`, `re`, `TokenizersBackend`, `VibeVoiceAcousticTokenizerFeatureExtractor`, `FastSpeech2ConformerTokenizer` - Fix 3-space indent in `_to_tuple` - Remove no-op in `fill_result_with_error` - Add `CHECKPOINT_REVISIONS` and `CHECKPOINT_SUBFOLDERS` module-level dicts to replace repetitive if/elif chains in `build_processor` - Extract `_build_model_tester_and_get_config` helper to eliminate duplicated tester instantiation + config-retrieval logic in `get_tiny_config` Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * remove other bad blocks * remove comment * fix wrong _models * revert * fix * fix * update workflow (to be continued) --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After the series of fixes in other previous PRs, we can now update the tiny model creation script. This update makes the script running without any failure, just 10 warnings.
There are many # TODO, some of them may just be quick remarks only. I decide to push and merge without removing them, so we still have the context to further improve the script to be more robust and clean.
The workflow file is also changed, so it could run on a daily basis, for us to check if there is any issue with the more future PRs merged into main. It doesn't upload the tiny models to the hub at this moment, which is a task for me to work on in a separate PR.