Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
When the test fetcher determines no tests need to run, CircleCI only creates the 'empty' job (no 'collection_job'). The GitHub workflow was failing at 'Get CircleCI run artifacts' because collection_job_number was empty, causing a broken curl URL. Add an early exit with artifact_found=false when collection_job_number is empty, matching the existing graceful skip for missing artifacts.
louzongzhi
pushed a commit
to louzongzhi/transformers
that referenced
this pull request
Apr 7, 2026
* empty commit * Fix GitHub workflow failing when CircleCI only runs empty job When the test fetcher determines no tests need to run, CircleCI only creates the 'empty' job (no 'collection_job'). The GitHub workflow was failing at 'Get CircleCI run artifacts' because collection_job_number was empty, causing a broken curl URL. Add an early exit with artifact_found=false when collection_job_number is empty, matching the existing graceful skip for missing artifacts. * More robustly handle missing collection_job and null artifacts response * Add comments explaining the defensive changes * Improve comments and use first // empty for failure_summary_url * fix * clean --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
sirzechs66
pushed a commit
to sirzechs66/transformers
that referenced
this pull request
Apr 18, 2026
* empty commit * Fix GitHub workflow failing when CircleCI only runs empty job When the test fetcher determines no tests need to run, CircleCI only creates the 'empty' job (no 'collection_job'). The GitHub workflow was failing at 'Get CircleCI run artifacts' because collection_job_number was empty, causing a broken curl URL. Add an early exit with artifact_found=false when collection_job_number is empty, matching the existing graceful skip for missing artifacts. * More robustly handle missing collection_job and null artifacts response * Add comments explaining the defensive changes * Improve comments and use first // empty for failure_summary_url * fix * clean --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
It's working, see https://github.com/huggingface/transformers/actions/runs/24025915210
(the failing job in this PR is because the workflow needs to be on
mainto be effective).