Fix resize failure caused by zero-sized masks in PP-DocLayoutV3#45281
Merged
vasqu merged 4 commits intohuggingface:mainfrom Apr 9, 2026
Merged
Fix resize failure caused by zero-sized masks in PP-DocLayoutV3#45281vasqu merged 4 commits intohuggingface:mainfrom
vasqu merged 4 commits intohuggingface:mainfrom
Conversation
Contributor
Author
|
@vasqu @zucchini-nlp @molbap PTAL. Thanks! |
vasqu
approved these changes
Apr 8, 2026
Contributor
vasqu
left a comment
There was a problem hiding this comment.
Can we add a small test to the image processor for such a case (dummy values). Otherwise, lgtm
Contributor
Author
|
@vasqu Done, PTAL |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: pp_doclayout_v3 |
vasqu
approved these changes
Apr 9, 2026
Contributor
vasqu
left a comment
There was a problem hiding this comment.
Thanks, just added a small comment for reference to this PR merging
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sirzechs66
pushed a commit
to sirzechs66/transformers
that referenced
this pull request
Apr 18, 2026
…ingface#45281) * Fix resize failure caused by zero-sized masks in PP-DocLayoutV3 * add small test * add small reference to PR --------- Co-authored-by: vasqu <antonprogamer@gmail.com> Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a boundary issue in the
_extract_polygon_points_by_masksmethod of PP-DocLayoutV3.When running inference with a low confidence threshold, or due to coordinate clipping during scaling, the extracted
cropped_maskcan sometimes have a size of 0 (empty array). This leads to a failure in subsequent operations (such as resize or polygon extraction).Changes
Added a defensive check in
_extract_polygon_points_by_masksto handle empty masks before processing: