Skip to content

Fix export for gemma4 and add Integration tests#45285

Merged
Cyrilvallez merged 11 commits intomainfrom
gemma4-tests
Apr 8, 2026
Merged

Fix export for gemma4 and add Integration tests#45285
Cyrilvallez merged 11 commits intomainfrom
gemma4-tests

Conversation

@Cyrilvallez
Copy link
Copy Markdown
Member

What does this PR do?

As per the title

@Cyrilvallez Cyrilvallez changed the title Update Gemma4 Integration tests Add Gemma4 Integration tests Apr 7, 2026
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Cyrilvallez
Copy link
Copy Markdown
Member Author

run-slow: gemma4

@Cyrilvallez Cyrilvallez changed the title Add Gemma4 Integration tests Fix export for gemma4 and add Integration tests Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/gemma4"]
quantizations: []

@Cyrilvallez
Copy link
Copy Markdown
Member Author

run-slow: gemma4

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 5d6ad971 workflow commit (merge commit)
PR b3dcf695 branch commit (from PR)
main dd6e8c5e base commit (on main)

⚠️ No test being reported (jobs are skipped or cancelled)!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/gemma4"]
quantizations: []

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN a3b75fc7 workflow commit (merge commit)
PR 32e9eafb branch commit (from PR)
main dd6e8c5e base commit (on main)

Model CI Report

2 new failed tests from this PR 😭

  • gemma4:
    tests/models/gemma4/test_modeling_gemma4.py::Gemma4IntegrationTest::test_model_4b_batch (✅ ⟹ ❌)
    tests/models/gemma4/test_modeling_gemma4.py::Gemma4IntegrationTest::test_model_text_only (✅ ⟹ ❌)

Copy link
Copy Markdown
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall smaller things imo

  • Local cache image
  • Maybe hub update gemma4 for the padding side

Comment thread tests/models/gemma4/test_modeling_gemma4.py Outdated
Comment thread tests/models/gemma4/test_modeling_gemma4.py Outdated
Comment thread tests/models/gemma4/test_modeling_gemma4.py Outdated
Comment thread tests/models/gemma4/test_modeling_gemma4.py Outdated
Comment thread tests/models/gemma4/test_modeling_gemma4.py Outdated
Comment thread src/transformers/integrations/executorch.py Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

[For maintainers] Suggested jobs to run (before merge)

run-slow: gemma4

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

View the CircleCI Test Summary for this PR:

https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=45285&sha=3728c8

@Cyrilvallez Cyrilvallez merged commit c850500 into main Apr 8, 2026
27 of 30 checks passed
@Cyrilvallez Cyrilvallez deleted the gemma4-tests branch April 8, 2026 13:07
ArthurZucker pushed a commit that referenced this pull request Apr 9, 2026
* start updating tests

* start making them pass

* more

* fix

* fix export

* fix

* oupsi

* review comments

* fix expectations for a10

* style

* rename tests
bigshanedogg pushed a commit to bigshanedogg/transformers that referenced this pull request Apr 9, 2026
* start updating tests

* start making them pass

* more

* fix

* fix export

* fix

* oupsi

* review comments

* fix expectations for a10

* style

* rename tests
@vasqu vasqu mentioned this pull request Apr 13, 2026
sirzechs66 pushed a commit to sirzechs66/transformers that referenced this pull request Apr 18, 2026
* start updating tests

* start making them pass

* more

* fix

* fix export

* fix

* oupsi

* review comments

* fix expectations for a10

* style

* rename tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants