Skip to content

fix: leak in tokenizer registry for test_processors#45318

Merged
tarekziade merged 2 commits intomainfrom
tarekziade-test-leak
Apr 9, 2026
Merged

fix: leak in tokenizer registry for test_processors#45318
tarekziade merged 2 commits intomainfrom
tarekziade-test-leak

Conversation

@tarekziade
Copy link
Copy Markdown
Collaborator

What does this PR do?

AutoTokenizer.register() adds classes to the global REGISTERED_TOKENIZER_CLASSES dict and some tests did not clean up behind them, leading to leaky state between tests

@tarekziade tarekziade requested review from hmellor and ydshieh April 8, 2026 13:46
@tarekziade
Copy link
Copy Markdown
Collaborator Author

run-slow: auto

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/auto"]
quantizations: []

@tarekziade tarekziade changed the title fix: leak in tokenizer reigstry fix: leak in tokenizer registry for test_processors Apr 8, 2026
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 4a429ee3 workflow commit (merge commit)
PR a4cb5028 branch commit (from PR)
main c850500b base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

@tarekziade tarekziade enabled auto-merge April 9, 2026 09:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

[For maintainers] Suggested jobs to run (before merge)

run-slow: auto

@tarekziade tarekziade added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit e683108 Apr 9, 2026
18 checks passed
@tarekziade tarekziade deleted the tarekziade-test-leak branch April 9, 2026 10:12
sirzechs66 pushed a commit to sirzechs66/transformers that referenced this pull request Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants