feat[vLLM × v5]: Add vLLM compatibility for audio models#45326
feat[vLLM × v5]: Add vLLM compatibility for audio models#45326ArthurZucker merged 4 commits intohuggingface:mainfrom
Conversation
|
The CI failures are unrelated to this PR (the GraniteSpeech failure is likely a pre-existing issue as I documented). |
|
cc @hmellor as well |
ArthurZucker
left a comment
There was a problem hiding this comment.
LGTM but can you make sure it's tested ! ?
|
[For maintainers] Suggested jobs to run (before merge) run-slow: audioflamingo3, auto, glmasr, granite_speech, musicflamingo, vibevoice_acoustic_tokenizer, vibevoice_asr |
@ArthurZucker So I tested Granite Speech, Audio Flamingo 3, GLM-ASR and VibeVoice-ASR (the changed models) again just to verify the tests pass, and they do, except the one I mentioned in the document previously which isn't related to this change. It's missing a skip like AudioFlamingo3 and Voxtral. Guess it doesn't hurt to add it so I've added it within the scope of this PR itself, and after that the CI is green (not sure about the local issue on my side when fetching the URL since it's actually valid, didn't happen in the last run). Before the necessary skip ( After the necessary skip (all model tests):
@eustlb Yupp it's tested :) |
|
Good day @ArthurZucker @eustlb, just checking in to see if there have been any updates so that the vLLM PR can be unblocked :) |
ArthurZucker
left a comment
There was a problem hiding this comment.
Let's go, I'd be happy if we can see some stuff than can be taken from the vllm PR to here to help standardize! 🤗
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Got kicked out of the merge queue 😓 |
…#45326) * chore: Add vLLM compat for audio models * fix: Fix ci/circleci: check_repository_consistency * nit: Skip incompatible test


What does this PR do?
→ This PR introduces compat fixes across several audio models to ensure they can be loaded and used by a companion vLLM PR. These changes are deliberate and are blocking this vLLM PR which adds audio backend compatibility to vLLM. Once this PR is merged, the other PR will be marked ready for review!
→ Outlining the design choices of one PR without context from the other didn't make much sense to me, so I wrote a doc that outlines both sets of changes together and explains their deliberate nature, amongst other valuable things!
→ The v5 tracker doesn’t mention the audio backend, but it is certainly a significant gap that needs to be addressed. After this is merged, I'll open an issue tracker for the Transformers audio backend work in vLLM so the efforts can stay organized.
Please refer to the document for the reasoning behind these changes in context with the vLLM PR!
Document: v5 x vLLM Audio Backend Support Document
Related Issues:
→ Current v5 tracker: vllm-project/vllm#38379
→ vllm-project/vllm#38902
@vasqu @ArthurZucker
Code Agent Policy
Before submitting
Pull Request section?
to it if that's the case.