Skip to content

chore: remove test_hub for now#45337

Merged
tarekziade merged 1 commit intomainfrom
tarek-deactivate-hub
Apr 9, 2026
Merged

chore: remove test_hub for now#45337
tarekziade merged 1 commit intomainfrom
tarek-deactivate-hub

Conversation

@tarekziade
Copy link
Copy Markdown
Collaborator

What does this PR do?

Removing test_hub from CI for now

@tarekziade tarekziade requested a review from ydshieh April 9, 2026 08:54
@tarekziade tarekziade self-assigned this Apr 9, 2026
Copy link
Copy Markdown
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's get rid of it for now.

In you opinion, would it be better to simply let "test_hub" to do nothing, but keep all other places to untouched (like test fetcher etc.), if we are ever to bring it back?

I mean around this block

            {"run": {
                "name": "Run tests",
                "command": f"({timeout_cmd} python3 -m pytest {marker_cmd} -n {self.pytest_num_workers} {junit_flags} {repeat_on_failure_flags} {' '.join(pytest_flags)} $(cat splitted_tests.txt) | tee tests_output.txt)"}
            },

But I am happy to keep what you have done in this PR. It's just another thought for you to judge

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

View the CircleCI Test Summary for this PR:

https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=45337&sha=9bfb97

@tarekziade tarekziade added this pull request to the merge queue Apr 9, 2026
@tarekziade
Copy link
Copy Markdown
Collaborator Author

OK, let's get rid of it for now.

In you opinion, would it be better to simply let "test_hub" to do nothing, but keep all other places to untouched (like test fetcher etc.), if we are ever to bring it back?

I mean around this block

            {"run": {
                "name": "Run tests",
                "command": f"({timeout_cmd} python3 -m pytest {marker_cmd} -n {self.pytest_num_workers} {junit_flags} {repeat_on_failure_flags} {' '.join(pytest_flags)} $(cat splitted_tests.txt) | tee tests_output.txt)"}
            },

But I am happy to keep what you have done in this PR. It's just another thought for you to judge

Thanks ! My hope is that once we've fixed the issues we could simply fully revert that change, so I have not focused on the how.

Merged via the queue into main with commit 03dd72d Apr 9, 2026
30 checks passed
@tarekziade tarekziade deleted the tarek-deactivate-hub branch April 9, 2026 09:28
tarekziade added a commit that referenced this pull request Apr 9, 2026
tarekziade added a commit that referenced this pull request Apr 15, 2026
tarekziade added a commit that referenced this pull request Apr 15, 2026
github-merge-queue Bot pushed a commit that referenced this pull request Apr 15, 2026
* warning

* simply pop the env so we don't hit the test hub

* we need to pop out before importing the lib

* simplify

* fmt

* wrong env

* ruff

* reordered

* bigger extract

* added a retry mechanism

* bumping up a few knobs

* remove dupe

* remove www.ilankelman.org from tests

* urls reorder

* display duration

* style

* bumping up more timeouts

* Revert "chore: remove test_hub for now (#45337)"

This reverts commit 03dd72d.

* fmt

* produce network metrics per test inline

* trigger at 30s (reruns)

* remove reruns

* EOL

* restored

* restored
sirzechs66 pushed a commit to sirzechs66/transformers that referenced this pull request Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants