add kwargs to all methods in the CallbackHandler class#45353
Merged
SunMarc merged 1 commit intohuggingface:mainfrom Apr 10, 2026
Merged
add kwargs to all methods in the CallbackHandler class#45353SunMarc merged 1 commit intohuggingface:mainfrom
SunMarc merged 1 commit intohuggingface:mainfrom
Conversation
Member
|
cc @SunMarc |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sirzechs66
pushed a commit
to sirzechs66/transformers
that referenced
this pull request
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
**kwargsto all methods in theCallbackHandlerclass. Previously, only theCallbackHandler.on_push_begin()method accepted**kwargs, while all other methods did not. This forces users who want to customize the Trainer class for their own use cases to modify methods in the CallbackHandler class, which is inconvenient. Adding**kwargsallows them to pass whatever they want to the CallbackHandler method calls and access those values in their own callback classes. Additionally, this makes the methods consistent with the template methods inTrainerCallback.Fixes # (issue)
Code Agent Policy
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc