fix gemma4 gradient accumulation loss and last token incorrect labels#45354
Merged
Cyrilvallez merged 2 commits intohuggingface:mainfrom Apr 10, 2026
Merged
fix gemma4 gradient accumulation loss and last token incorrect labels#45354Cyrilvallez merged 2 commits intohuggingface:mainfrom
Cyrilvallez merged 2 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gemma3n, gemma4 |
Cyrilvallez
approved these changes
Apr 10, 2026
Member
Cyrilvallez
left a comment
There was a problem hiding this comment.
Thanks @winglian! Reflected the change in modular, and added gemma3n as well at the same time!
sirzechs66
pushed a commit
to sirzechs66/transformers
that referenced
this pull request
Apr 18, 2026
…huggingface#45354) * fix gemma4 gradient accumulation loss and last token incorrect labels * modular + also gemma3n --------- Co-authored-by: Cyril Vallez <cyril.vallez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Gemma 4 was calculating the CE loss incorrectly and not handling gradient accumulation steps properly, leading to losses scaled up by the value of the gradient accumulation steps rather than letting the built in HF CE loss function handle it correctly with
num_items_in_batch. Gemma 4's custom loss function was simply using attention mask to filter out tokens, but we already handle this via whenlabelsare set to-100.Additionally, when doing multimodal training, the loss often starts off at ~15. This is partly attributed to most multimodal datasets being out of distribution (I tested this by having Gemma 4 generate a response to a prompt and checking the loss for that and it was closs to a more normal ~1 loss. The second reason is that the logit/label shift and could result in the last token in a sequence trying to predict a token like a pad token and it wouldn't be masked out because the original loss function didn't handle this, but using properl
-100labels does.Fixes # (issue)
Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker @Cyrilvallez @zucchini-nlp
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.