fix: check CUDA availability before calling get_device_capability#45371
Closed
HelloAnner wants to merge 1 commit intohuggingface:mainfrom
Closed
fix: check CUDA availability before calling get_device_capability#45371HelloAnner wants to merge 1 commit intohuggingface:mainfrom
HelloAnner wants to merge 1 commit intohuggingface:mainfrom
Conversation
Fixes huggingface#45341 When CUDA is installed but no GPU is available, testing_utils.py line 3223 calls torch.cuda.get_device_capability() which fails. Changed the condition to check torch.cuda.is_available() before accessing GPU capabilities.
Collaborator
|
Thanks for the fix, but this is a duplicate of #45351, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45341
When CUDA is installed but no GPU is available,
get_device_properties()callstorch.cuda.get_device_capability()which fails because there is no CUDA device.The fix moves
import torchto the top of the function and adds atorch.cuda.is_available()check to the condition, so the function gracefully falls through to the else branch when no GPU is present.