Fix the response schema for the gemma4 converter#45411
Conversation
|
cc @vasqu but don't worry about reviewing too deeply since I've already iterated on this schema with the people at Google! |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gemma4 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
Trusting you but could you add which commits were related to these changes. Meaning those on the hub and it to the PR description here.
|
I would like to say to add a test but we don't really add tests to converters per se but the end product :D |
|
@vasqu there's actually no original commit on the Hub that corresponds to the conversion script schema, I think - we were developing the schema live before the launch, and the conversion script went out of date pretty quickly because we were focused on the repos! |
4 participants
This PR fixes the response schema used in the Gemma4 conversion script. The change has already been made in the Hub repos themselves, so I'm just copying the updated schema into the codebase!