chore(qa): split pipeline and add type checking#45432
Merged
tarekziade merged 4 commits intomainfrom Apr 24, 2026
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=45432&sha=3eecdd |
Collaborator
Author
|
see #45458 |
Cyrilvallez
approved these changes
Apr 23, 2026
Member
Cyrilvallez
left a comment
Cyrilvallez
left a comment
There was a problem hiding this comment.
Fine by me thanks! cc @Rocketknight1 as well before merging!
Rocketknight1
approved these changes
Apr 24, 2026
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
Yes, looks good! I'm guessing the existing pipeline code triggered the complexity filter you're adding, which is why it has to be refactored in this PR? It's fine if so - that init was quite old and could definitely use the cleanup.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This patch adds the pipeline in our type checker, and also adds mccabe complexity in our Ruff linter with a 75 threshold for now.
To reduce complexity, logical blocks are now splitted into private functions to improve maintainability and readability.