fix: return empty tuple when protobuf not available#45466
Closed
Jah-yee wants to merge 1 commit intohuggingface:mainfrom
Closed
fix: return empty tuple when protobuf not available#45466Jah-yee wants to merge 1 commit intohuggingface:mainfrom
Jah-yee wants to merge 1 commit intohuggingface:mainfrom
Conversation
…g ImportError Previously, import_protobuf_decode_error() raised ImportError when protobuf wasn't installed, even when the actual exception was a different type (e.g., ValueError, RuntimeError). This caused the real error to be hidden. Now returns empty tuple () when protobuf is not available, so the except clause matches nothing and allows the actual exception to propagate. This matches the suggested fix in issue huggingface#45459.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45459 - Previously import_protobuf_decode_error() raised ImportError when protobuf wasn't installed even for other exceptions, hiding the real error. Now returns empty tuple () so the actual exception propagates.