Fix: propagate interpolate_pos_encoding through Pixio model hierarchy#45469
Closed
Spectual wants to merge 1 commit intohuggingface:mainfrom
Closed
Fix: propagate interpolate_pos_encoding through Pixio model hierarchy#45469Spectual wants to merge 1 commit intohuggingface:mainfrom
Spectual wants to merge 1 commit intohuggingface:mainfrom
Conversation
…s, PixioModel, and PixioBackbone PixioPatchEmbeddings.forward already accepted an interpolate_pos_encoding flag (inherited from ViTPatchEmbeddings) to skip image-size validation for variable-resolution inputs, but neither PixioEmbeddings nor PixioModel nor PixioBackbone exposed or passed that flag, making it impossible to use the model on images with non-default sizes. Fixes huggingface#44716
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: pixio |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PixioPatchEmbeddings.forwardalready accepted aninterpolate_pos_encodingflag (inherited fromViTPatchEmbeddings) to skip image-size validation and allow variable-resolution inputs. However, neitherPixioEmbeddings,PixioModel, norPixioBackboneexposed or forwarded that flag, making it impossible to use the model on images with non-default sizes.This PR adds the
interpolate_pos_encodingparameter to each of those three classes and threads it through the call chain.Fixes #44716
Code Agent Policy
Before submitting
PixioPatchEmbeddings.forwardsupportsinterpolate_pos_encodingbut it is not propagated throughPixioEmbeddings/PixioModel#44716Who can review?
@yonigozlan @molbap