Skip to content

[Conversion Mapping] Small fixups#45483

Merged
vasqu merged 4 commits intomainfrom
fix-conversion-mapping
Apr 20, 2026
Merged

[Conversion Mapping] Small fixups#45483
vasqu merged 4 commits intomainfrom
fix-conversion-mapping

Conversation

@vasqu
Copy link
Copy Markdown
Contributor

@vasqu vasqu commented Apr 16, 2026

Fixup some conversion mappings --> everything should live directly under mapping except we add onto it

  • Solar change is the same as qwen2 moe
  • Cohere moved
  • Ernie moe similar to minimax with one additional rename

@vasqu vasqu changed the title fix [Conversion Mapping] Small fixups Apr 16, 2026
@vasqu
Copy link
Copy Markdown
Contributor Author

vasqu commented Apr 16, 2026

run-slow: cohere_asr, ernie4_5_moe, solar_open

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/cohere_asr", "models/ernie4_5_moe", "models/solar_open"]
quantizations: []

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Apr 16, 2026

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 7b8ce807 workflow commit (merge commit)
PR d9950781 branch commit (from PR)
main 947eff6e base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

zucchini-nlp
zucchini-nlp reviewed Apr 17, 2026
View reviewed changes
Comment thread src/transformers/conversion_mapping.py
Comment on lines -546 to -548
mapping["solar_open"] = [
WeightConverter(
source_patterns=[
Copy link
Copy Markdown
Member

@zucchini-nlp zucchini-nlp Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it safe to delete? from PR description seems like mapping["solar_open"] = mapping["qwen2_moe"].copy()

Copy link
Copy Markdown
Contributor Author

@vasqu vasqu Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have it already here

transformers/src/transformers/conversion_mapping.py

Line 51 in ff4f96a

"solar_open": "qwen2_moe",

Not sure why this was even recreated, not rushing to merge. Asked @3outeille whether this was really needed

Copy link
Copy Markdown
Member

@zucchini-nlp zucchini-nlp Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow, didn't see that

@vasqu
Copy link
Copy Markdown
Contributor Author

vasqu commented Apr 20, 2026

run-slow: cohere_asr, ernie4_5_moe, solar_open

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/cohere_asr", "models/ernie4_5_moe", "models/solar_open"]
quantizations: []

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN d4e91e3d workflow commit (merge commit)
PR 5904edc8 branch commit (from PR)
main 79f90bc6 base commit (on main)

Model CI Report

❌ 1 new failed tests from this PR 😭

  • cohere_asr:
    tests/models/cohere_asr/test_modeling_cohere_asr.py::CohereAsrModelTest::test_reverse_loading_mapping (✅ ⟹ ❌)

@vasqu
Copy link
Copy Markdown
Contributor Author

vasqu commented Apr 20, 2026

run-slow: cohere_asr

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/cohere_asr"]
quantizations: []

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 9a625dc5 workflow commit (merge commit)
PR 97fde4f8 branch commit (from PR)
main 79f90bc6 base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

@vasqu vasqu enabled auto-merge April 20, 2026 13:37
@vasqu vasqu added this pull request to the merge queue Apr 20, 2026
Merged via the queue into main with commit 0db3379 Apr 20, 2026
30 checks passed
@vasqu vasqu deleted the fix-conversion-mapping branch April 20, 2026 14:01
lvliang-intel pushed a commit to lvliang-intel/transformers that referenced this pull request Apr 21, 2026
@vasqu @lvliang-intel
[Conversion Mapping] Small fixups (huggingface#45483)
ffe6f88 
* fix

* fix
artem-spector pushed a commit to artem-spector/transformers that referenced this pull request Apr 21, 2026
@vasqu
[Conversion Mapping] Small fixups (huggingface#45483)
3186e59 
* fix

* fix
@evalstate evalstate mentioned this pull request Apr 28, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zucchini-nlp zucchini-nlp zucchini-nlp left review comments

@3outeille 3outeille 3outeille approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vasqu @HuggingFaceDocBuilderDev @3outeille @zucchini-nlp