revert sha commit pointing to main for transformers_amd_ci_ workflows#45495
revert sha commit pointing to main for transformers_amd_ci_ workflows#45495
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the AMD scheduled CI caller workflows to reference the reusable workflows in huggingface/hf-workflows via the main branch instead of a pinned commit SHA, so those scheduled runs track the latest upstream workflow definitions.
Changes:
- Switch
uses: huggingface/hf-workflows/...@<sha>to...@mainfor AMD MI250 scheduled CI callers. - Switch
uses: huggingface/hf-workflows/...@<sha>to...@mainfor AMD MI325 (ARC scale set) scheduled CI callers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| .github/workflows/self-scheduled-amd-mi325-caller.yml | Updates MI325 scheduled CI reusable-workflow references from a pinned SHA to @main. |
| .github/workflows/self-scheduled-amd-mi250-caller.yml | Updates MI250 scheduled CI reusable-workflow references from a pinned SHA to @main. |
| torch-pipeline: | ||
| name: Torch pipeline CI | ||
| uses: huggingface/hf-workflows/.github/workflows/transformers_amd_ci_scheduled_arc_scale_set.yaml@63657f571a92cc9759159442936061c51d6d9ae4 # main | ||
| uses: huggingface/hf-workflows/.github/workflows/transformers_amd_ci_scheduled_arc_scale_set.yaml@main |
There was a problem hiding this comment.
Using a mutable ref (@main) for a reusable workflow means this scheduled CI can change behavior without any change in this repo, which hurts reproducibility and can unexpectedly break scheduled runs. Since this workflow also inherits secrets on self-hosted runners, pinning to a specific commit SHA (or a version tag) is safer and makes changes auditable.
| example-ci: | ||
| name: Example CI | ||
| uses: huggingface/hf-workflows/.github/workflows/transformers_amd_ci_scheduled_arc_scale_set.yaml@63657f571a92cc9759159442936061c51d6d9ae4 # main | ||
| uses: huggingface/hf-workflows/.github/workflows/transformers_amd_ci_scheduled_arc_scale_set.yaml@main |
There was a problem hiding this comment.
Using a mutable ref (@main) for a reusable workflow means this scheduled CI can change behavior without any change in this repo, which hurts reproducibility and can unexpectedly break scheduled runs. Since this workflow also inherits secrets on self-hosted runners, pinning to a specific commit SHA (or a version tag) is safer and makes changes auditable.
| deepspeed-ci: | ||
| name: DeepSpeed CI | ||
| uses: huggingface/hf-workflows/.github/workflows/transformers_amd_ci_scheduled_arc_scale_set.yaml@63657f571a92cc9759159442936061c51d6d9ae4 # main | ||
| uses: huggingface/hf-workflows/.github/workflows/transformers_amd_ci_scheduled_arc_scale_set.yaml@main |
There was a problem hiding this comment.
Using a mutable ref (@main) for a reusable workflow means this scheduled CI can change behavior without any change in this repo, which hurts reproducibility and can unexpectedly break scheduled runs. Since this workflow also inherits secrets on self-hosted runners, pinning to a specific commit SHA (or a version tag) is safer and makes changes auditable.
| model-ci: | ||
| name: Model CI | ||
| uses: huggingface/hf-workflows/.github/workflows/transformers_amd_ci_scheduled.yaml@a88e7fa2eaee28de5a4d6142381b1fb792349b67 # main | ||
| uses: huggingface/hf-workflows/.github/workflows/transformers_amd_ci_scheduled.yaml@main |
There was a problem hiding this comment.
Using a mutable ref (@main) for a reusable workflow means this scheduled CI can change behavior without any change in this repo, which hurts reproducibility and can unexpectedly break scheduled runs. Since this workflow also inherits secrets on self-hosted runners, pinning to a specific commit SHA (or a version tag) is safer and makes changes auditable.
| torch-pipeline: | ||
| name: Torch pipeline CI | ||
| uses: huggingface/hf-workflows/.github/workflows/transformers_amd_ci_scheduled.yaml@a88e7fa2eaee28de5a4d6142381b1fb792349b67 # main | ||
| uses: huggingface/hf-workflows/.github/workflows/transformers_amd_ci_scheduled.yaml@main |
There was a problem hiding this comment.
Using a mutable ref (@main) for a reusable workflow means this scheduled CI can change behavior without any change in this repo, which hurts reproducibility and can unexpectedly break scheduled runs. Since this workflow also inherits secrets on self-hosted runners, pinning to a specific commit SHA (or a version tag) is safer and makes changes auditable.
| example-ci: | ||
| name: Example CI | ||
| uses: huggingface/hf-workflows/.github/workflows/transformers_amd_ci_scheduled.yaml@a88e7fa2eaee28de5a4d6142381b1fb792349b67 # main | ||
| uses: huggingface/hf-workflows/.github/workflows/transformers_amd_ci_scheduled.yaml@main |
There was a problem hiding this comment.
Using a mutable ref (@main) for a reusable workflow means this scheduled CI can change behavior without any change in this repo, which hurts reproducibility and can unexpectedly break scheduled runs. Since this workflow also inherits secrets on self-hosted runners, pinning to a specific commit SHA (or a version tag) is safer and makes changes auditable.
| deepspeed-ci: | ||
| name: DeepSpeed CI | ||
| uses: huggingface/hf-workflows/.github/workflows/transformers_amd_ci_scheduled.yaml@a88e7fa2eaee28de5a4d6142381b1fb792349b67 # main | ||
| uses: huggingface/hf-workflows/.github/workflows/transformers_amd_ci_scheduled.yaml@main |
There was a problem hiding this comment.
Using a mutable ref (@main) for a reusable workflow means this scheduled CI can change behavior without any change in this repo, which hurts reproducibility and can unexpectedly break scheduled runs. Since this workflow also inherits secrets on self-hosted runners, pinning to a specific commit SHA (or a version tag) is safer and makes changes auditable.
| model-ci: | ||
| name: Model CI | ||
| uses: huggingface/hf-workflows/.github/workflows/transformers_amd_ci_scheduled_arc_scale_set.yaml@63657f571a92cc9759159442936061c51d6d9ae4 # main | ||
| uses: huggingface/hf-workflows/.github/workflows/transformers_amd_ci_scheduled_arc_scale_set.yaml@main |
There was a problem hiding this comment.
Using a mutable ref (@main) for a reusable workflow means this scheduled CI can change behavior without any change in this repo, which hurts reproducibility and can unexpectedly break scheduled runs. Since this workflow also inherits secrets on self-hosted runners, pinning to a specific commit SHA (or a version tag) is safer and makes changes auditable.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What does this PR do?
Fixes # (issue)
Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.