qa: re-run modular converter when the script itself is modified#45528
qa: re-run modular converter when the script itself is modified#45528tarekziade merged 1 commit intomainfrom
Conversation
| high_res_size: dict | ||
| high_res_resample: Union["PILImageResampling", int] | ||
| high_res_image_mean: float | list[float] | tuple[float, ...] | ||
| high_res_image_std: float | list[float] | tuple[float, ...] |
There was a problem hiding this comment.
actually very much looks like caused by #45492, could you verify it is really unrelated?
There was a problem hiding this comment.
What happened is that the PR change the modular conversion process and that was impacting other models as well. They were not checked in the PR because it's ignored for models not changed in the PR.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: conditional_detr, deepseek_vl, deepseek_vl_hybrid, deformable_detr, ernie4_5_vl_moe, grounding_dino, mask2former, paddleocr_vl, rt_detr, segformer, smolvlm, video_llama_3 |
tarekziade
force-pushed
the
tarekziade-consistency
branch
from
53c0123 to
4efaa53
Compare
tarekziade
changed the title
| # Changes to any of these files can alter the generated output for every modular model, | ||
| # so touching them must force a full re-check (see `converter_changed_in_diff`). | ||
| CONVERTER_FILES = { | ||
| "utils/modular_model_converter.py", | ||
| "utils/create_dependency_mapping.py", | ||
| } | ||
|
|
| class ConverterChangedInDiffTest(unittest.TestCase): | ||
| """Regression guard for PR #45492: changes to the converter alone must force a full check.""" | ||
|
|
||
| def _patch_modified(self, files): |
There was a problem hiding this comment.
hmm not sure if we need unittests tho, I don't think anyone will delete modular_model_converter.py from the checker
There was a problem hiding this comment.
this is not deleting the file, it's just simulating a change in modular_model_converter.py in the diff to make sure that we detect it, so we run the modular converter on all model like in main and not partially skip. It's what happened in #45492
There was a problem hiding this comment.
yeah, I got it, I meant delete the you added for "diff on modular_model_converter.py" with a commont why it is there
…o_diff` shortcut since changing the checker might impact models not in the PR
tarekziade
force-pushed
the
tarekziade-consistency
branch
from
4efaa53 to
cb3ed62
Compare
tarekziade
changed the title
…ingface#45528) when changing the checker itself, we want to ignore the `guaranteed_no_diff` shortcut since changing the checker might impact models not in the PR
…ingface#45528) when changing the checker itself, we want to ignore the `guaranteed_no_diff` shortcut since changing the checker might impact models not in the PR
3 participants
What does this PR do?
guaranteed_no_diffshortcut since changing the checker might impact models not in the PR