Fix AMD CI: rebuild torchvision with libjpeg + refresh expectations#45533
Merged
Abdennacer-Badaoui merged 3 commits intohuggingface:mainfrom Apr 21, 2026
Merged
Fix AMD CI: rebuild torchvision with libjpeg + refresh expectations#45533Abdennacer-Badaoui merged 3 commits intohuggingface:mainfrom
Abdennacer-Badaoui merged 3 commits intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: modernbert, qwen2_5_vl |
Collaborator
|
run-slow: modernbert, qwen2_5_vl |
Contributor
|
This comment contains models: ["models/modernbert", "models/qwen2_5_vl"] |
tarekziade
reviewed
Apr 21, 2026
|
|
||
| # Rebuild torchvision so decode_image has libjpeg and ROCm image ops stay on GPU. | ||
| RUN python3 -m pip install --no-cache-dir "setuptools<81" pybind11 | ||
| RUN TV_VERSION=$(python3 -c "import torchvision; print(torchvision.__version__.split('+')[0])") && \ |
Collaborator
There was a problem hiding this comment.
just curious, what did install torchvision prior to this line so we have to remove it? could we skip that initial install?
tarekziade
approved these changes
Apr 21, 2026
Collaborator
tarekziade
left a comment
tarekziade
left a comment
There was a problem hiding this comment.
LGTM to land just a question about the torchvision dep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torchvisionfrom source in the AMD CI image sotorchvision.io.decode_image(used byload_image_as_tensor) has libjpeg/libpng support. This unblocks the wave ofdecode_jpeg: torchvision not compiled with libjpeg supportfailures introduced when image loading switched from PIL totorchvision.ioin this PR. The build is working, see here.FORCE_CUDA=1and filtering hipify-emitted*_hip.cppbreadcrumbs out of the sources globs.qwen2_5_vlandmodernbert. These drifted because the AMD image pins flash-attention to an older commit (6387433…) to keep the Docker build under the 6h GitHub Actions limit (~4h with the pin, >6h on newer heads), and that version produces slightly different numerics on the affected tests.