Draft
Conversation
7 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is motivated to simplify changes required for vLLM compatibility as seen in #39330
Fix a discrepancy in ALMs design compared to VLMs that for most of them don't have a base model class because the use the causal model for the text model directly, while Llava style (which is indeed more aligned with the lib philosophy) is rather:
XxModel: encoder + projector + language base model backbone
XxForConditionalGeneration: XxModel + lm_head
why do we actually have this discrepancy?
qwen2_audio was the first ALM in transformers, modelling reflects the status of llava when it was added
all the ALMs merged since then replicated this.
llava and VLMs evolved thanks to
base_model#41589get_decoder()for multimodal and delete redundant code 🔪 #42156how do we ensure BC
model.language_modeldiff with how it's been done for VLM
I'd rather use the introduced
@forward_base_model_attrsthat avoid having to add as done for VLMsclearer IMO and avoid forgetting in the future why such a thing was added in the first place.
🚨🚨🚨
We don't fully ensure BC, this is breaking:
AutoModel.from_pretrained("Qwen/Qwen2-Audio-7B")now returnsQwen2AudioModel, notQwen2AudioForConditionalGeneration, some for other ALMs 🚨TODO