Skip to content

[Sam3LiteText] Remove unnecessary modules/configs#45535

Merged
vasqu merged 2 commits intohuggingface:mainfrom
yonigozlan:fix-sam3-lite-text
Apr 21, 2026
Merged

[Sam3LiteText] Remove unnecessary modules/configs#45535
vasqu merged 2 commits intohuggingface:mainfrom
yonigozlan:fix-sam3-lite-text

Conversation

@yonigozlan
Copy link
Copy Markdown
Member

I missed that some last minute modifications to modular in #44320 added unnecessary configs and modules in the modeling code

Cc @vasqu, @NielsRogge

@yonigozlan yonigozlan requested review from NielsRogge and vasqu April 20, 2026 23:17
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Collaborator

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, more proper modular usage is always good 🫡

@vasqu
Copy link
Copy Markdown
Contributor

vasqu commented Apr 21, 2026

run-slow: sam3_lite_text

@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: sam3_lite_text

@github-actions
Copy link
Copy Markdown
Contributor

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/sam3_lite_text"]
quantizations: []

@github-actions
Copy link
Copy Markdown
Contributor

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN a45f471e workflow commit (merge commit)
PR 79142e24 branch commit (from PR)
main 67fb8bb3 base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

@vasqu vasqu added this pull request to the merge queue Apr 21, 2026
Merged via the queue into huggingface:main with commit 7439ac0 Apr 21, 2026
24 checks passed
@vasqu vasqu mentioned this pull request Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants