[modular] Fix modular logic broken in #45045#45539
Merged
Cyrilvallez merged 9 commits intomainfrom Apr 22, 2026
Merged
Conversation
Cyrilvallez
changed the title
Cyrilvallez
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: conditional_detr, deepseek_vl, deformable_detr, efficientloftr, ernie4_5_vl_moe, glm_image, grounding_dino, lightglue, llava_onevision, mask2former, paddleocr_vl, rt_detr, segformer, smolvlm, video_llama_3, yolos |
Cyrilvallez
changed the title
Cyrilvallez
changed the title
Member
Author
|
Got offline approval from the lm_head @ArthurZucker, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Revert all changes to modular that were added in #45045. The changes break modular's purpose, as it takes the nodes from modular verbatim, meaning they cannot use inheritance which is the desired usage of modular. See e.g. here where the nice inheritance had to be removed and use full definition instead, which is really against modular's purpose... There are many more similar instances in the same PR.
This PR does the same, but without breaking modular's logic!