Skip to content

Fix local_files_only tokenizer fallback when tokenizer files are missing (Issue 45538)#45541

Open
Brianzhengca wants to merge 5 commits intohuggingface:mainfrom
Brianzhengca:clip_tokenizer_max_model_length
Open

Fix local_files_only tokenizer fallback when tokenizer files are missing (Issue 45538)#45541
Brianzhengca wants to merge 5 commits intohuggingface:mainfrom
Brianzhengca:clip_tokenizer_max_model_length

Conversation

@Brianzhengca
Copy link
Copy Markdown

What does this PR do?

Fixes #45538

Root Cause

from_pretrained(..., local_files_only=True) let missing tokenizer files resolve to None and still proceeded into _from_pretrained(...). That allowed a stub tokenizer to initialize instead of raising, which led to the bogus huge model_max_length.

Describe the Fix

The fix adds a fail-closed check in PreTrainedTokenizerBase.from_pretrained.

After resolving files, it now checks whether all real tokenizer assets for that class resolved to None.
If they did, it raises the existing Can't load tokenizer... OSError instead of continuing into
_from_pretrained(...) and constructing a stub tokenizer

Local Tests

  • Check with BertTokenizer and CLIPTokenizer using a nonexistent model id and
    local_files_only=True.
    Before the fix, they loaded unexpectedly with the huge fallback max length.
    After the fix, they raised the expected OSError.

Code Agent Policy

The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.

PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.

This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read CONTRIBUTING.md.

  • I confirm that this is not a pure code agent PR.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker @Cyrilvallez

Copy link
Copy Markdown
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Failing tests are related:

FAILED tests/models/auto/test_tokenization_auto.py::AutoTokenizerTest::test_custom_tokenizer_with_mismatched_tokenizer_class - OSError: Can't load tokenizer for 'hf-internal-testing/test_unregistered_dynamic'. If you were trying to load it from 'https://huggingface.co/models', make sure you don't have a local directory with the same name. Otherwise, make sure 'hf-internal-testing/test_unregistered_dynamic' is the correct path to a directory containing all relevant files for a NopTokenizer tokenizer.
FAILED tests/models/auto/test_tokenization_auto.py::AutoTokenizerTest::test_init_tokenizer_with_trust - OSError: Can't load tokenizer for 'hf-internal-testing/test_unregistered_dynamic'. If you were trying to load it from 'https://huggingface.co/models', make sure you don't have a local directory with the same name. Otherwise, make sure 'hf-internal-testing/test_unregistered_dynamic' is the correct path to a directory containing all relevant files for a NopTokenizer tokenizer.

and DIA ones, can you please fix them accordingly? 🤗

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Brianzhengca
Copy link
Copy Markdown
Author

@ArthurZucker, just fixed my code for the tests. Please take a look when you have time. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLIPTokenizer uses 10**30 as model_max_length

4 participants