fix: raise clear error when tokenizer config uses v5 list format on older versions#45566
Closed
armorbreak001 wants to merge 1 commit intohuggingface:mainfrom
Closed
Conversation
…lder versions When loading a model with a v5-style extra_special_tokens (list format) on transformers < 5.0, _set_model_specific_special_tokens crashes with a misleading AttributeError: 'list' object has no attribute 'keys'. Add an early type check that raises a clear, actionable ValueError telling users to upgrade.
Contributor
|
This PR was flagged by our automated quality checks. If you're a genuine Common reasons for flagging:
We appreciate your contribution and apologize if this is a false positive! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When loading a model whose
tokenizer_config.jsonuses the v5-style list-basedextra_special_tokensformat on transformers < 5.0,_set_model_specific_special_tokens()crashes with a misleading:This sends users down the wrong debugging path (patching config files, reinstalling packages) when the real issue is a version mismatch.
Fix
Add an
isinstance(special_tokens, list)guard at the top of_set_model_specific_special_tokens()that raises a clearValueErrortelling users to upgrade to transformers >= 5.0.0.Fixes #45376