Fix AttributeError on s_aux=None in flash_attention_forward#45589
Merged
ArthurZucker merged 1 commit intohuggingface:mainfrom Apr 23, 2026
Merged
Fix AttributeError on s_aux=None in flash_attention_forward#45589ArthurZucker merged 1 commit intohuggingface:mainfrom
AttributeError on s_aux=None in flash_attention_forward#45589ArthurZucker merged 1 commit intohuggingface:mainfrom
Conversation
`flash_attention_forward` unconditionally called `s_aux.to(query.dtype)`, which crashed with `AttributeError: 'NoneType' object has no attribute 'to'` for models that don't use attention sinks (e.g. Gemma). Mirrors the parallel guard added in huggingface#40434 for `flash_paged.py`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
kaixuanliu
approved these changes
Apr 23, 2026
vasqu
added
the
for patch
ArthurZucker
approved these changes
Apr 23, 2026
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Yep let's patch asap
ArthurZucker
pushed a commit
that referenced
this pull request
Apr 23, 2026
…5589) Guard `s_aux` cast in `flash_attention_forward` for sink-less models `flash_attention_forward` unconditionally called `s_aux.to(query.dtype)`, which crashed with `AttributeError: 'NoneType' object has no attribute 'to'` for models that don't use attention sinks (e.g. Gemma). Mirrors the parallel guard added in #40434 for `flash_paged.py`. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
tarekziade
pushed a commit
that referenced
this pull request
Apr 23, 2026
…5589) Guard `s_aux` cast in `flash_attention_forward` for sink-less models `flash_attention_forward` unconditionally called `s_aux.to(query.dtype)`, which crashed with `AttributeError: 'NoneType' object has no attribute 'to'` for models that don't use attention sinks (e.g. Gemma). Mirrors the parallel guard added in #40434 for `flash_paged.py`. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45588
@ArthurZucker @yonigozlan @molbap