fix #45588: guard s_aux against None in flash_attention_forward#45590
Conversation
Fixes #45588 - AttributeError when s_aux=None for sink-less models Bug: flash_attention_forward unconditionally calls s_aux.to(query.dtype), but s_aux defaults to None and sink-less models (e.g. Gemma 4) never pass s_aux, causing AttributeError: 'NoneType' object has no attribute 'to' Fix: Add guard to only convert s_aux when it is not None. Similar pattern was already used in flash_paged.py (PR #40434). Test: python syntax check passed
Contributor
|
This PR was flagged by our automated quality checks. If you're a genuine Common reasons for flagging:
We appreciate your contribution and apologize if this is a false positive! |
ghost
closed this by deleting the head repository
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #45588
Bug
flash_attention_forwardunconditionally callss_aux.to(query.dtype), buts_auxdefaults toNoneand sink-less models (e.g. Gemma 4) never passs_aux, causing:Fix
Add a guard to only convert
s_auxwhen it is notNone:This pattern was already used in
flash_paged.py(see PR #40434).Testing
Notes
Automated high-quality fix