Skip to content

Add regression test for Gemma4 audio relative positional range#45607

Closed
mathceo wants to merge 5 commits intohuggingface:mainfrom
mathceo:gemma4-audio-rel-pos-test
Closed

Add regression test for Gemma4 audio relative positional range#45607
mathceo wants to merge 5 commits intohuggingface:mainfrom
mathceo:gemma4-audio-rel-pos-test

Conversation

@mathceo
Copy link
Copy Markdown
Contributor

@mathceo mathceo commented Apr 23, 2026

What does this PR do?

Adds a regression test for Gemma4AudioRelPositionalEncoding with a non-default audio config.

Follow-up to #45606.

@mathceo
Copy link
Copy Markdown
Contributor Author

mathceo commented Apr 23, 2026

@vasqu small note: this follow-up test PR currently fails on main because it depends on the fix in #45606. Once #45606 is merged, I can update this branch so the regression test runs against the fixed behavior.

@vasqu
Copy link
Copy Markdown
Contributor

vasqu commented Apr 23, 2026

Imo, it makes more sense to have it directly in the other PR before merge cc @eustlb

@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: gemma4

@github-actions
Copy link
Copy Markdown
Contributor

View the CircleCI Test Summary for this PR:

https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=45607&sha=077c09

@vasqu
Copy link
Copy Markdown
Contributor

vasqu commented Apr 27, 2026

Closing this in favor of #45606 (where this has been included and attributed :D)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants