Fix configuration reading and error handling for kernels#45610
Merged
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
vasqu
approved these changes
Apr 23, 2026
Contributor
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
LGTM overall, I don't really think we need the changes in fp8 - would be nice if you could clarify that
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
Feel free to merge after the conversion mapping + getattr detail 🤗 |
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=45610&sha=a18eb3 |
vasqu
pushed a commit
that referenced
this pull request
Apr 23, 2026
* Fix missing conversion of experts Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * Fix eager config attribute reading Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * Add proper error when kernels isn't installed Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * remove unnecessary mapping Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * review comments Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * remove double newline Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> --------- Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com>
vasqu
added
the
for patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following issues when trying to run Qwen3.6 FP8 checkpoints such as
Qwen/Qwen3.5-35B-A3B-FP8. This PR fixes the following issues:nn.ModuleListbut the necessaryWeightConverters were missingkernelswas not installed it failed with a confusing attribute errorFP8Experts.__init__so models which use the primary name fail with attribute errorsCloses #44230