Fix peft constructors#45622
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Thanks for working on a fix, this resolves the failing transformers test. In PEFT, the corresponding tests are still failing, but I will port the changes from here over to PEFT and that should do the trick. Is there any way we can make all of this more robust? It's not the first time things break. I assume this is because we rely on Transformers-internal implementation details. Is there a public, more stable API that we can use instead? |
|
Those are indeed relying on internals, which is why it wasn't detected! If you can add a simple fast test performing one of those conversions, it would catch any regresions though! |
|
@Cyrilvallez I could convert |
|
Yes 100% |
After a change in huggingface/transformers#45448, weight conversion tests started failing. Transformers provided a fix in huggingface/transformers#45622 but it needs to be ported to PEFT too. This PR, together with the Transformers fix, resolves the issue.
What does this PR do?
As per the title. Fixes #45448 (comment)
cc @BenjaminBossan