Add supports_gradient_checkpointing to NemotronHPreTrainedModel#45625
Merged
ArthurZucker merged 2 commits intohuggingface:mainfrom Apr 27, 2026
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: nemotron_h |
5 tasks
ArthurZucker
pushed a commit
that referenced
this pull request
Apr 28, 2026
…45625) Add supports_gradient_checkpointing to NemotronHPreTrainedModel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables gradient checkpointing for
NemotronHby settingsupports_gradient_checkpointing = TrueonNemotronHPreTrainedModel. The idea comes from its usage in TRL.NemotronHBlockalready inherits fromGradientCheckpointingLayer, so the infrastructure at the block level is in place. The only missing piece was the class-level flag, which currently defaults toFalse(inherited fromPreTrainedModel). As a result, any call tomodel.gradient_checkpointing_enable()(including the one issued byTrainerwhengradient_checkpointing=True) raises:This is a simple omission, not a limitation of the architecture. All sibling hybrid Mamba/attention models in the library already enable it:
GradientCheckpointingLayersupports_gradient_checkpointingGraniteMoeHybrid is the closest analogue (MoE + hybrid Mamba/attention, same layout as NemotronH).
The change is made in
modular_nemotron_h.pyand propagated tomodeling_nemotron_h.pyviautils/modular_model_converter.py.Fixes the failure seen downstream in huggingface/trl#5278, where NemotronH tests required a
gradient_checkpointing=Falseworkaround.Fixes # (issue)
Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Who can review?
@ArthurZucker @Cyrilvallez