Skip to content

chore(typing): add ty type checking for 3 pipeline files#45667

Merged
tarekziade merged 4 commits intohuggingface:mainfrom
moonbogi:typing/add-pipeline-files
Apr 29, 2026
Merged

chore(typing): add ty type checking for 3 pipeline files#45667
tarekziade merged 4 commits intohuggingface:mainfrom
moonbogi:typing/add-pipeline-files

Conversation

@moonbogi
Copy link
Copy Markdown
Contributor

Adds ty type checking coverage for:

  • src/transformers/pipelines/feature_extraction.py
  • src/transformers/pipelines/image_feature_extraction.py
  • src/transformers/pipelines/video_classification.py

For Issues #45458

What does this PR do?

Adds ty type checking coverage for three pipeline files as part of the
incremental typing effort. These files had no existing type errors and
required no code changes with only registration in utils/check_types.py
under CHECKER_CONFIG.

Fixes # (issue)

Code Agent Policy

The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.

PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.

This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read CONTRIBUTING.md.

  • I confirm that this is not a pure code agent PR.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Adds ty type checking coverage for:
- src/transformers/pipelines/feature_extraction.py
- src/transformers/pipelines/image_feature_extraction.py
- src/transformers/pipelines/video_classification.py

For Issues huggingface#45438
Copy link
Copy Markdown
Collaborator

@tarekziade tarekziade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution. _typing should stay in the list

Comment thread utils/check_types.py
"src/transformers/quantizers/**/*.py",
".circleci/create_circleci_config.py",
],
"check_args": [
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be removed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tarekziade, I've restored src/transformers/_typing.py in check_args
as requested. Thanks for the prompt review!

@tarekziade tarekziade self-assigned this Apr 29, 2026
Copy link
Copy Markdown
Collaborator

@tarekziade tarekziade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@tarekziade tarekziade enabled auto-merge April 29, 2026 06:34
@tarekziade tarekziade added this pull request to the merge queue Apr 29, 2026
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Merged via the queue into huggingface:main with commit 74d576b Apr 29, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants