chore(typing): add ty type checking for 3 pipeline files#45667
Merged
tarekziade merged 4 commits intohuggingface:mainfrom Apr 29, 2026
Merged
chore(typing): add ty type checking for 3 pipeline files#45667tarekziade merged 4 commits intohuggingface:mainfrom
tarekziade merged 4 commits intohuggingface:mainfrom
Conversation
Adds ty type checking coverage for: - src/transformers/pipelines/feature_extraction.py - src/transformers/pipelines/image_feature_extraction.py - src/transformers/pipelines/video_classification.py For Issues huggingface#45438
tarekziade
reviewed
Apr 28, 2026
Collaborator
tarekziade
left a comment
There was a problem hiding this comment.
thanks for your contribution. _typing should stay in the list
| "src/transformers/quantizers/**/*.py", | ||
| ".circleci/create_circleci_config.py", | ||
| ], | ||
| "check_args": [ |
Collaborator
There was a problem hiding this comment.
this should not be removed
Contributor
Author
There was a problem hiding this comment.
Hi @tarekziade, I've restored src/transformers/_typing.py in check_args
as requested. Thanks for the prompt review!
tarekziade
approved these changes
Apr 29, 2026
Collaborator
tarekziade
left a comment
There was a problem hiding this comment.
Thanks for the contribution
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ty type checking coverage for:
For Issues #45458
What does this PR do?
Adds
tytype checking coverage for three pipeline files as part of theincremental typing effort. These files had no existing type errors and
required no code changes with only registration in
utils/check_types.pyunder
CHECKER_CONFIG.Fixes # (issue)
Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request section?
to it if that's the case. Add typing support incrementally (meta issue) #45458
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.