Exclude audio modules from conversion process#45683
Open
softguy777 wants to merge 1 commit intohuggingface:mainfrom
Open
Exclude audio modules from conversion process#45683softguy777 wants to merge 1 commit intohuggingface:mainfrom
softguy777 wants to merge 1 commit intohuggingface:mainfrom
Conversation
Add logic to exclude audio modules from conversion to prevent uint8 crash in multimodal models.
Member
|
cc @SunMarc |
SunMarc
reviewed
Apr 29, 2026
| } | ||
| modules_to_not_convert = tied_keys | last_module_key | output_emb_keys | ||
|
|
||
| # remove audio modules for multimodal models to prevent uint8 crash |
Member
There was a problem hiding this comment.
update the comment, this is not only for unint8 crash but just not worth quantizing it as it is quite small already
SunMarc
reviewed
Apr 29, 2026
Comment on lines
+61
to
+63
| for name, _ in model.named_modules(): | ||
| if "audio_tower" in name or "embed_audio" in name: | ||
| modules_to_not_convert.add(name) |
Member
There was a problem hiding this comment.
is there a better way to check if we have an audio module. also i don't want to add all modules in it, only the top should be added. Make sure you add some tests also for bnb for example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add logic to exclude audio modules from conversion to prevent uint8 crash in multimodal models.
As discussed in the issue, this prevents the torch.finfo() TypeError on uint8 weights during 4-bit inference for multimodal models like Gemma 4, and preserves audio encoder fidelity.
What does this PR do?
Fixes #45672, Fixes #45674
Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.