Add regression test for MusicgenMelody audio conditioning (GH #45647)#45737
Open
voodoovampire wants to merge 6 commits intohuggingface:mainfrom
Open
Add regression test for MusicgenMelody audio conditioning (GH #45647)#45737voodoovampire wants to merge 6 commits intohuggingface:mainfrom
voodoovampire wants to merge 6 commits intohuggingface:mainfrom
Conversation
|
Hey @voodoovampire - thanks for the co-author credit! Could you update the email in the co-authored-by line to adityachoksi2512@gmail.com? The current one is an old work email that won't link to my GitHub profile. Also looks like there's a duplicate entry with a slightly different username. Thanks! |
…Fixes huggingface#45647 Co-authored-by: adityachoksi2512 <adityachoksi2512@gmail.com>
…er investigation" This reverts commit d9ce46e.
77d04d5 to
0be51a4
Compare
Author
|
Hey bro @adityachoksi2512 - absolutely! Just updated the co-authored-by email to adityachoksi2512@gmail.com. The duplicate was my mistake - I initially used the work email from your original commit metadata. Should be fixed now! |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: musicgen_melody |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a regression test for issue #45647.
Test behavior:
AutoProcessorwithtext=["jazz"], same seed, same params.1e-3in mean absolute difference.Current status:
On
facebook/musicgen-melody, this test fails withmean abs diff=0.00000000, confirming that audio conditioning is ignored.Next step:
This test provides a reliable repro. The model fix is being coordinated with @adityachoksi2512, who has already bisected the regression to the cache refactor in PR #38635.
Closes #45647 (once the model fix is merged).