[fsmt test] basic config test with online model + super tiny model#7860
[fsmt test] basic config test with online model + super tiny model#7860LysandreJik merged 5 commits intohuggingface:masterfrom
Conversation
|
Hi Stas, thanks, #7659 will fix this (we will now require at least one example checkpoint for each tokenizer and we test it automatically). |
|
@thomwolf, I'm not certain why you closed this. This is a tokenizer test that is needed - the issue caught in examples was just a flag that there was a missing test in the normal tests. Actually, not only it's needed, I will have to expand this test to verify that it doesn't get the hardcoded default values, but fetches the correct values from Feel free to add it as part of #7659 but please make sure you used different from I hope this makes sense. |
|
Hmm, but you copied I haven't read the new code in depth, but my gut feeling is that the defaults may mask a problem. |
|
Hi stas, I'll let you read the new code and then we can have a look together. The basic idea is that we now require a full and working checkpoint for the tokenizers to be fully tested in various conditions and the slow vs. fast compared. The question of testing that tokenizers load and use |
|
That works. But please re-open this PR, since we need it anyway. I will add more changes to it after your big PR merge to ensure that the loading of the tokenizer is properly tested. |
|
This PR is complete now. |
This PR does:
@LysandreJik, @sshleifer