Skip to content

[cleanup] pegasus,marian,mbart pytorch tests#8033

Merged
LysandreJik merged 1 commit intohuggingface:masterfrom
sshleifer:pt-test-cleanup
Oct 26, 2020
Merged

[cleanup] pegasus,marian,mbart pytorch tests#8033
LysandreJik merged 1 commit intohuggingface:masterfrom
sshleifer:pt-test-cleanup

Conversation

@sshleifer
Copy link
Copy Markdown
Contributor

@sshleifer sshleifer commented Oct 25, 2020

  • Cleans up 3 pytorch test files
  • Faster (num_beams=2) pegasus integration test.

@sshleifer sshleifer added cleanup Tests Related to tests labels Oct 25, 2020
@sshleifer sshleifer changed the title [pegasus,marian,mbart] cleanup pytorch tests [cleanup] pegasus,marian,mbart pytorch tests Oct 25, 2020
Copy link
Copy Markdown
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjustments look good.

expected_src_tokens = [8274, 127873, 25916, 7, 8622, 2071, 438, 67485, 53, 187895, 23, 51712, 2, EN_CODE]

@slow
@unittest.skip("This has been failing since June 20th at least.")
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have zero context on why you're removing that test, if you could just explain?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has never really been passing, I don't even remember why I checked it in.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then, I guess

Copy link
Copy Markdown
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LysandreJik LysandreJik merged commit 8bbe824 into huggingface:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants