Add mixed precision evaluation#8036
Merged
sgugger merged 2 commits intohuggingface:masterfrom Oct 26, 2020
Merged
Conversation
sgugger
suggested changes
Oct 26, 2020
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Thanks for the PR! It's very clean for mixed-precision with torch >= 1.6! Two things though, I don't think we should add another argument and just use the existing fp16 parameter for this. With torch <= 1.5 and the flag fp16 passed, the model will be in FP16 precision, so evaluation is done in FP16.
Contributor
Author
|
I see your point; Apex will take care of the other case. Updated! |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add flag and code to do mixed precision forward in trainer's
prediction_stepfunction.Let evaluation (and prediction) to run faster.
Who can review?
@sgugger