Use return_dict in RagModel forward pass#8665
Closed
lhoestq wants to merge 1 commit intohuggingface:masterfrom
Closed
Use return_dict in RagModel forward pass#8665lhoestq wants to merge 1 commit intohuggingface:masterfrom
lhoestq wants to merge 1 commit intohuggingface:masterfrom
Conversation
Member
Author
|
Closing since it was fixed in #8585 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were changes in the output format of models bu it looks like the RagModel forward pass was not updated to use
return_dictas noticed in #8653I'm running the slow tests right now. If they pass I will update from draft pull request to open request