[training] SAVE_STATE_WARNING was removed in pytorch#8979
Merged
Conversation
FYI `SAVE_STATE_WARNING` has been removed 3 days ago: pytorch/pytorch#46813 Fixes: #8232 @sgugger
Collaborator
|
Thank God they removed that horrible thing! Instead of the complex parsing, maybe a |
Contributor
Author
|
no horrible formatting that way! good idea - done. |
binshengliu
pushed a commit
to binshengliu/transformers
that referenced
this pull request
Mar 5, 2021
* [training] SAVE_STATE_WARNING was removed in pytorch FYI `SAVE_STATE_WARNING` has been removed 3 days ago: pytorch/pytorch#46813 Fixes: huggingface#8232 @sgugger * style, but add () to prevent autoformatters from botching it * switch to try/except * cleanup
calpt
added a commit
to adapter-hub/adapters
that referenced
this pull request
Mar 8, 2021
|
@stas00, could it be possible to apply your fix to the code of version |
Contributor
Author
|
@LysandreJik, your help is needed here. I don't know anything about how old branches maintenance is done. This PR was merged in 4x series and @vyshkant is requesting this fix applied to 3.5.x for the next release. Thank you. |
Collaborator
|
No we won't do fixes for old versions, either upgrade to v4 or use PyTorch < 1.8 if you want to stick to v3.5. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SAVE_STATE_WARNINGhas been removed from pytorch 3 days ago: pytorch/pytorch#46813I had to add redundant ()'s to avoid a terrible auto-formatter outcome.
Fixes: #8232
@sgugger, @LysandreJik