replace apex.normalization.FusedLayerNorm with torch.nn.LayerNorm#9386
Merged
patrickvonplaten merged 1 commit intohuggingface:masterfrom Jan 4, 2021
Merged
replace apex.normalization.FusedLayerNorm with torch.nn.LayerNorm#9386patrickvonplaten merged 1 commit intohuggingface:masterfrom
patrickvonplaten merged 1 commit intohuggingface:masterfrom
Conversation
8 tasks
patrickvonplaten
approved these changes
Jan 3, 2021
Contributor
patrickvonplaten
left a comment
patrickvonplaten
left a comment
There was a problem hiding this comment.
This looks good to me!
sgugger
approved these changes
Jan 4, 2021
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Way easier this way, LGTM!
15 tasks
Contributor
|
Merging since it's blocking #9343 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to drop
apex.normalization.FusedLayerNormin favor of fastertorch.nn.LayerNorm.apex.normalization.FusedLayerNormcorrupts data under model parallel FusedLayerNorm corrupts data when switching devices NVIDIA/apex#1022Fixes: #9377
@LysandreJik, @sgugger, @patrickvonplaten