fix T5 head mask in model_parallel#9726
Merged
patrickvonplaten merged 2 commits intohuggingface:masterfrom Jan 21, 2021
Merged
Conversation
Contributor
|
That's a better solution actually! Thanks @patil-suraj |
Contributor
|
Also, there is a whole bunch of issues including this one I believe fixed in this PR: #9323 where we no longer do it one by one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
head_maskin T5 is not parallelized correctly in model parallel, each layer's head mask should be put on that layer's device if it's notNone.Fixes #9718