distilbert: fix creation of sinusoidal embeddings#9917
Merged
LysandreJik merged 1 commit intohuggingface:masterfrom Feb 3, 2021
stefan-it:master
Merged
distilbert: fix creation of sinusoidal embeddings#9917LysandreJik merged 1 commit intohuggingface:masterfrom stefan-it:master
LysandreJik merged 1 commit intohuggingface:masterfrom
stefan-it:master
Conversation
VictorSanh
approved these changes
Feb 3, 2021
Contributor
VictorSanh
left a comment
There was a problem hiding this comment.
lgtm! thanks @stefan-it
LysandreJik
approved these changes
Feb 3, 2021
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
similar issue as reported by @stas00 with BART, see #8226.
The creation of sinusoidal embeddings is currently not working on PyTorch 1.8+.
It fails with:
I've seen this problem when trying to train a model in Flair with DistilBERT as feature-based embeddings, as well as when training a DistilBERT model from scratch using the official example.
It can be reproduced in a
nvcr.io/nvidia/pytorch:20.12-py3container, that comes with PyTorch 1.8.