Support for SFTTrainer.evaluate() and SFTTrainer.predict() with null train_dataset#2004
Merged
lewtun merged 7 commits intohuggingface:mainfrom Sep 13, 2024
Merged
Conversation
lewtun
approved these changes
Sep 11, 2024
Member
lewtun
left a comment
lewtun
left a comment
There was a problem hiding this comment.
Thanks for extending the SFTTrainer to support evaluation-only @Sohaib9920! LGTM
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
…ull train_dataset (huggingface#2004) * add null train_dataset check * Fix pre-commit errors --------- Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow using
SFTTrainerfor only evaluation/prediction whentrain_datasetisNone.Resolves the exception and passes the
sft_trainertest.Before submitting
Pull Request section?
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.