Skip to content

[Draft] Add eval_data_collator arg#2311

Closed
pdufour wants to merge 1 commit intohuggingface:mainfrom
pdufour:train_predict_support
Closed

[Draft] Add eval_data_collator arg#2311
pdufour wants to merge 1 commit intohuggingface:mainfrom
pdufour:train_predict_support

Conversation

@pdufour
Copy link
Copy Markdown

@pdufour pdufour commented Nov 3, 2024

What does this PR do?

Note: not ready for review until huggingface/transformers#32346 lands.

This adds support for the new eval_data_collator arg which was added in the above PR.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@pdufour pdufour changed the title Add eval_data_collator arg [Draft] Add eval_data_collator arg Nov 3, 2024
@tcz
Copy link
Copy Markdown

tcz commented Nov 26, 2024

How would you make an eval_data_collator from DataCollatorForCompletionOnlyLM?

@qgallouedec
Copy link
Copy Markdown
Member

I'm closing this PR because no recent activity. Please feel free to reopen it or request a reopening if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants