🔮 Native VLM support for SFTTrainer#3862
Merged
qgallouedec merged 45 commits intomainfrom Aug 13, 2025
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
merveenoyan
reviewed
Aug 7, 2025
Contributor
merveenoyan
left a comment
There was a problem hiding this comment.
are we still going to use sft_vlm.py? if so, AutoModelForVision2Seq is no longer a valid class, it's actually not used at all, I think most models are migrated to AutoModelForImageTextToText
Member
|
I'd aim to remove them all if possible. |
SFTTrainerSFTTrainer
merveenoyan
approved these changes
Aug 8, 2025
Contributor
merveenoyan
left a comment
There was a problem hiding this comment.
PR is good, also tested on multiple models
only me running on accelerate didn't work well but it might be me lol
Co-authored-by: Sergio Paniego Blanco <sergiopaniegoblanco@gmail.com>
qgallouedec
commented
Aug 9, 2025
qgallouedec
commented
Aug 9, 2025
5 tasks
LuisVasquezBSC
pushed a commit
to langtech-bsc/trl
that referenced
this pull request
Aug 28, 2025
Co-authored-by: Sergio Paniego Blanco <sergiopaniegoblanco@gmail.com> Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>
LuisVasquezBSC
pushed a commit
to langtech-bsc/trl
that referenced
this pull request
Aug 28, 2025
Co-authored-by: Sergio Paniego Blanco <sergiopaniegoblanco@gmail.com> Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>
SamY724
pushed a commit
to SamY724/trl
that referenced
this pull request
Sep 6, 2025
Co-authored-by: Sergio Paniego Blanco <sergiopaniegoblanco@gmail.com> Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all CI failures unrelated