🥓 [docs] add CP docs#3994
Merged
qgallouedec merged 31 commits intomainfrom Sep 9, 2025
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
reviewed
Sep 2, 2025
|
|
||
| **Option 1: Using SFTConfig** | ||
|
|
||
| **With Wrapped Strategy:** |
Member
There was a problem hiding this comment.
I recommend not mentionning "wrapped" in the documentation. I feel like this is a very advanced use, and it somewhat distracts from the message of this section.
qgallouedec
reviewed
Sep 2, 2025
qgallouedec
reviewed
Sep 2, 2025
qgallouedec
reviewed
Sep 2, 2025
qgallouedec
reviewed
Sep 2, 2025
qgallouedec
reviewed
Sep 2, 2025
qgallouedec
reviewed
Sep 2, 2025
qgallouedec
reviewed
Sep 2, 2025
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
Collaborator
Author
|
i'll undo my change |
lewtun
reviewed
Sep 3, 2025
Member
lewtun
left a comment
lewtun
left a comment
There was a problem hiding this comment.
Nice doc! Overall LGTM with @qgallouedec comments about avoiding the wrapped example
| from trl import SFTConfig | ||
|
|
||
| training_args = SFTConfig( | ||
| max_seq_length=2048, # Long sequence length |
Member
There was a problem hiding this comment.
Maybe we can make this truly long like 16384 tokens?
|
|
||
| #### Accelerate Configuration | ||
|
|
||
| Create an accelerate config file (e.g. `context_parallel_config.yaml` for 2 GPUs): |
Member
There was a problem hiding this comment.
I wonder if it makes sense to have a copy of this in accelerate_configs/fsdp2_cp.yaml so there's a standard reference people can work from? If you agree, I'd make it to run on 8 GPUs which is the default for our other configs
Collaborator
Author
There was a problem hiding this comment.
ok yes good idea with 8 gpus
Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
Collaborator
Author
|
still needs huggingface/transformers#40619 |
Co-authored-by: Sergio Paniego Blanco <sergiopaniegoblanco@gmail.com>
Co-authored-by: Sergio Paniego Blanco <sergiopaniegoblanco@gmail.com>
Collaborator
Author
|
@qgallouedec forgot to checkin the yaml... try now |
Co-authored-by: Sergio Paniego Blanco <sergiopaniegoblanco@gmail.com>
Co-authored-by: Sergio Paniego Blanco <sergiopaniegoblanco@gmail.com>
Co-authored-by: Sergio Paniego Blanco <sergiopaniegoblanco@gmail.com>
kashif
commented
Sep 4, 2025
qgallouedec
reviewed
Sep 9, 2025
qgallouedec
reviewed
Sep 9, 2025
qgallouedec
reviewed
Sep 9, 2025
qgallouedec
reviewed
Sep 9, 2025
qgallouedec
reviewed
Sep 9, 2025
qgallouedec
reviewed
Sep 9, 2025
|
|
||
| #### Training Configuration | ||
|
|
||
| You can configure context parallelism training either programmatically or via command line: |
Member
There was a problem hiding this comment.
just realized that this is not accurate, as you always have to pass the accelerate config. I'll refactor a bit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add example and docs for CP SFT training.